Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] [NFC] Use APFloat semantics to get floating type width #107372

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[MLIR] [NFC] Use APFloat semantics to get floating type width #107372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb4556d
[MLIR] Use APFloat semantics to get floating type width
sergey-kozub Sep 5, 2024
9487c1f
Merge branch 'main' into mlir-float-getwidth
sergey-kozub Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions mlir/lib/IR/BuiltinTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,23 +91,12 @@ IntegerType IntegerType::scaleElementBitwidth(unsigned scale) {
//===----------------------------------------------------------------------===//

unsigned FloatType::getWidth() {
if (llvm::isa<Float6E3M2FNType>(*this))
return 6;
if (llvm::isa<Float8E5M2Type, Float8E4M3Type, Float8E4M3FNType,
Float8E5M2FNUZType, Float8E4M3FNUZType, Float8E4M3B11FNUZType,
Float8E3M4Type>(*this))
return 8;
if (llvm::isa<Float16Type, BFloat16Type>(*this))
return 16;
if (llvm::isa<Float32Type, FloatTF32Type>(*this))
// The actual width of TF32 is 19 bits. However, since it is a truncated
// version of Float32, we treat it as 32 bits in MLIR FloatType::getWidth
// for compatibility.
if (llvm::isa<FloatTF32Type>(*this))
return 32;
Copy link
Member

@apivovarov apivovarov Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment noting that the actual width of TF32 is 19 bits. However, since it is a truncated version of Float32, we treat it as 32 bits in MLIR FloatType::getWidth for compatibility.

@jfurtek, @jpienaar , @River707 What are your thoughts on this approach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comment, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine I think, this is NFC right? (please edit the PR title)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't have a problem with this either

if (llvm::isa<Float64Type>(*this))
return 64;
if (llvm::isa<Float80Type>(*this))
return 80;
if (llvm::isa<Float128Type>(*this))
return 128;
llvm_unreachable("unexpected float type");
return APFloat::semanticsSizeInBits(getFloatSemantics());
}

/// Returns the floating semantics for the given type.
Expand Down
Loading