[llvm][Mips] Bail on underaligned loads/stores in FastISel. #106231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 28, 2024
Until llvm/llvm-project#106231 trickles down.
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 28, 2024
Until llvm/llvm-project#106231 trickles down.
topperc
reviewed
Aug 29, 2024
alexrp
force-pushed
the
llvm-mips-underaligned-ldst
branch
from
e2102e7 to
caa9db1
Compare
wzssyqa
reviewed
Sep 2, 2024
|
Added handling for r6 in FastISel and updated the test to exercise more configurations. |
alexrp
force-pushed
the
llvm-mips-underaligned-ldst
branch
from
caa9db1 to
1299cc9
Compare
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
Until llvm/llvm-project#106231 trickles down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered this problem in Zig, causing all of our
mips(el)-linux-gnueabi*tests to fail: ziglang/zig#21215For these unusual cases, let's just bail in
MipsFastISelsinceMipsTargetLoweringcan handle them fine.Note: I don't have commit access.