Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Apply NoRecurse attrib to all HLSL functions #105907

Merged
merged 1 commit into from
Aug 29, 2024

Commits on Aug 24, 2024

  1. Apply NoRecurse attrib to all HLSL functions

    Previously, functions named "main" got the NoRecurse attribute consistent
    with the behavior of C++, which HLSL largely follows. However,
    standard recursion is not allowed in HLSL, so all functions should
    really have this attribute. This doesn't prevent recursion, but
    rather signals that these functions aren't expected to recurse.
    
    Practically, this was done so that entry point functions named "main"
    would have all have the same attributes as otherwise identical
    entry points with other names.
    
    This required small changes to the this assignment tests because they
    no longer generate so many attribute sets since more of them match.
    
    related to llvm#105244
    but done to simplify testing for llvm#89806
    pow2clk committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2c4d773 View commit details
    Browse the repository at this point in the history