Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-rt][test] Disable lld tests on SPARC #100533

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rorth
Copy link
Collaborator

@rorth rorth commented Jul 25, 2024

As detailed in Issue #100320, a considerable number of tests that explicitly use -fuse-ld=lld FAIL on Linux/sparc64 due to several lld limitations (no 32-bit SPARC support, lack of support for various relocations, ...).

To reduce the noise, this patch disables COMPILER_RT_HAS_LLD on SPARC wholesale.

Tested on sparc64-unknown-linux-gnu.

As detailed in Issue llvm#100320, a considerable number of tests that
explicitly use `-fuse-ld=lld` `FAIL` on Linux/sparc64 due to several `lld`
limitations (no 32-bit SPARC support, lack of support for various
relocations, ...).

To reduce the noise, this patch disables `COMPILER_RT_HAS_LLD` on SPARC
wholesale.

Tested on `sparc64-unknown-linux-gnu`.
@rorth rorth requested a review from vitalybuka July 25, 2024 08:44
@rorth
Copy link
Collaborator Author

rorth commented Jul 25, 2024

There's something weird going on here: the tests in question are guarded
with lld-available, which is ultimately set from
COMPILER_RT_HAS_LLD_PYBOOL. The latter (or COMPILER_RT_HAS_LLD
actually) is set in compiler-rt/CMakeLists.txt. The code block in
question is only entered because LINKER_IS_LLD is TRUE, although I have
no idea where this is set. However, that's wrong because clang uses
ld.bfd instead. The next snippet is totally weird: the reference to
.../tools/lld probably dates before the monorepo and can go. The next
one, checking for .../lld in the source tree, is equally spurious: in the
monorepo, that directory will always exist. I can make absolutely no sense
of all this.

@rorth rorth merged commit 33a50e0 into llvm:main Jul 29, 2024
8 checks passed
@rorth rorth added this to the LLVM 19.X Release milestone Jul 29, 2024
@rorth
Copy link
Collaborator Author

rorth commented Jul 29, 2024

/cherry-pick 33a50e0

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 29, 2024
As detailed in Issue llvm#100320, a considerable number of tests that
explicitly use `-fuse-ld=lld` `FAIL` on Linux/sparc64 due to several
`lld` limitations (no 32-bit SPARC support, lack of support for various
relocations, ...).

To reduce the noise, this patch disables `COMPILER_RT_HAS_LLD` on SPARC
wholesale.

Tested on `sparc64-unknown-linux-gnu`.

(cherry picked from commit 33a50e0)
@llvmbot
Copy link
Member

llvmbot commented Jul 29, 2024

/pull-request #100979

tru pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 29, 2024
As detailed in Issue llvm#100320, a considerable number of tests that
explicitly use `-fuse-ld=lld` `FAIL` on Linux/sparc64 due to several
`lld` limitations (no 32-bit SPARC support, lack of support for various
relocations, ...).

To reduce the noise, this patch disables `COMPILER_RT_HAS_LLD` on SPARC
wholesale.

Tested on `sparc64-unknown-linux-gnu`.

(cherry picked from commit 33a50e0)
banach-space pushed a commit to banach-space/llvm-project that referenced this pull request Aug 7, 2024
As detailed in Issue llvm#100320, a considerable number of tests that
explicitly use `-fuse-ld=lld` `FAIL` on Linux/sparc64 due to several
`lld` limitations (no 32-bit SPARC support, lack of support for various
relocations, ...).

To reduce the noise, this patch disables `COMPILER_RT_HAS_LLD` on SPARC
wholesale.

Tested on `sparc64-unknown-linux-gnu`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants