Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm/IR/RuntimeLibcalls.h has introduced layering violation #99610

Closed
chapuni opened this issue Jul 19, 2024 · 2 comments
Closed

llvm/IR/RuntimeLibcalls.h has introduced layering violation #99610

chapuni opened this issue Jul 19, 2024 · 2 comments
Labels
llvm:ir

Comments

@chapuni
Copy link
Contributor

chapuni commented Jul 19, 2024

#98512 introduced layering violation, including CodeGen from IR.
This also brought vt_gen into LLVMCore.

I strongly suggest reverting #98512 (c05126b, bb604ae, and 5b54f36), at the moment.

I guess it can be rewritten with IR stuff.
@chapuni chapuni mentioned this issue Jul 19, 2024
Merged
@MaskRay
Copy link
Member

MaskRay commented Jul 19, 2024

I support reverting the patches. LLVM:Core should not include CodeGen includes, even if they are header-only.

chapuni added a commit that referenced this issue Jul 20, 2024
@chapuni
Revert "[LLVM][LTO] Factor out RTLib calls and allow them to be dropp…
740161a 
…ed (#98512)"

This reverts commit c05126b.
(llvmorg-19-init-17714-gc05126bdfc3b)
See #99610
chapuni added a commit that referenced this issue Jul 20, 2024
@chapuni
Revert "[LLVM][LTO] Add missing dependency"
e2965fe 
This reverts commit bb604ae.
(llvmorg-19-init-17804-gbb604ae9b8ad)
See #99610
chapuni added a commit that referenced this issue Jul 20, 2024
@chapuni
Revert "[bazel] Fix llvm:Core build (#99054)"
168ecd7 
This reverts commit 5b54f36.
(llvmorg-19-init-17774-g5b54f36fb607)
See #99610
@chapuni
Copy link
Contributor Author

chapuni commented Jul 20, 2024

Reverted. Cc: @jhuber6

@chapuni chapuni closed this as completed Jul 20, 2024
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this issue Jul 23, 2024
@chapuni @sgundapa
Revert "[LLVM][LTO] Factor out RTLib calls and allow them to be dropp…
980d30c 
…ed (llvm#98512)"

This reverts commit c05126b.
(llvmorg-19-init-17714-gc05126bdfc3b)
See llvm#99610
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this issue Jul 23, 2024
@chapuni @sgundapa
Revert "[LLVM][LTO] Add missing dependency"
8e9d532 
This reverts commit bb604ae.
(llvmorg-19-init-17804-gbb604ae9b8ad)
See llvm#99610
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this issue Jul 23, 2024
@chapuni @sgundapa
Revert "[bazel] Fix llvm:Core build (llvm#99054)"
12f3165 
This reverts commit 5b54f36.
(llvmorg-19-init-17774-g5b54f36fb607)
See llvm#99610
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@chapuni @yuxuanchen1997
Revert "[LLVM][LTO] Factor out RTLib calls and allow them to be dropp…
ae26072 
…ed (#98512)"

This reverts commit c05126b.
(llvmorg-19-init-17714-gc05126bdfc3b)
See #99610
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@chapuni @yuxuanchen1997
Revert "[LLVM][LTO] Add missing dependency"
5eea09e 
This reverts commit bb604ae.
(llvmorg-19-init-17804-gbb604ae9b8ad)
See #99610
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@chapuni @yuxuanchen1997
Revert "[bazel] Fix llvm:Core build (#99054)"
ad9ccaf 
This reverts commit 5b54f36.
(llvmorg-19-init-17774-g5b54f36fb607)
See #99610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
llvm:ir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chapuni @MaskRay @EugeneZelenko