Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM][NEON] NEON lowering doesn't legalize ISD::ABDS/ABDU nodes #94466

Closed
RKSimon opened this issue Jun 5, 2024 · 1 comment · Fixed by #94504
Closed

[ARM][NEON] NEON lowering doesn't legalize ISD::ABDS/ABDU nodes #94466

RKSimon opened this issue Jun 5, 2024 · 1 comment · Fixed by #94504
Labels
backend:ARM

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Jun 5, 2024

Noticed while working #92576 - MVE supports these nodes, but NEON doesn't and just has support for the int_arm_neon_vabds/int_arm_neon_vabdu intrinsics and a couple of hardcoded patterns to support the VABDL extension instructions.
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 5, 2024

@llvm/issue-subscribers-backend-arm

Author: Simon Pilgrim (RKSimon)

Noticed while working #92576 - MVE supports these nodes, but NEON doesn't and just has support for the int_arm_neon_vabds/int_arm_neon_vabdu intrinsics and a couple of hardcoded patterns to support the VABDL extension instructions.

RKSimon added a commit to RKSimon/llvm-project that referenced this issue Jun 5, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes.
ffbf52a 
As noted on llvm#94466, NEON has ABDS/ABDU instructions but only handles then via intrinsics, plus some VABDL custom patterns.

I'm not clear how ARM handles intrinsic -> ISD mapping, so I've left all the intrinsics handling in place so far at the moment.

Ideally all the VABD/VABA/VABDL/VABAL handling should be moved to using the abds/abdu nodes - but am I on the right track?

Fixes llvm#94466
@RKSimon RKSimon mentioned this issue Jun 5, 2024
Merged
RKSimon added a commit to RKSimon/llvm-project that referenced this issue Jun 6, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes.
2f9a635 
As noted on llvm#94466, NEON has ABDS/ABDU instructions but only handles then via intrinsics, plus some VABDL custom patterns.

Fixes llvm#94466
RKSimon added a commit to RKSimon/llvm-project that referenced this issue Jun 6, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes.
8c8b7ea 
As noted on llvm#94466, NEON has ABDS/ABDU instructions but only handles them via intrinsics, plus some VABDL custom patterns.

Fixes llvm#94466
RKSimon added a commit to RKSimon/llvm-project that referenced this issue Jun 6, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes.
1d0899e 
As noted on llvm#94466, NEON has ABDS/ABDU instructions but only handles them via intrinsics, plus some VABDL custom patterns.

Fixes llvm#94466
RKSimon added a commit to RKSimon/llvm-project that referenced this issue Jun 7, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes.
6b4fa32 
As noted on llvm#94466, NEON has ABDS/ABDU instructions but only handles them via intrinsics, plus some VABDL custom patterns.

Fixes llvm#94466
RKSimon added a commit that referenced this issue Jun 7, 2024
@RKSimon
[ARM] Add NEON support for ISD::ABDS/ABDU nodes. (#94504)
c0b4685 
As noted on #94466, NEON has ABDS/ABDU instructions but only handles them via intrinsics, plus some VABDL custom patterns.

This patch flags basic ABDS/ABDU for neon types as legal and updates all tablegen patterns to use abds/abdu instead.

Fixes #94466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend:ARM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ARM] Add NEON support for ISD::ABDS/ABDU nodes. RKSimon/llvm-project
2 participants
@RKSimon @llvmbot