clang/include/clang/AST/Redeclarable.h: 4 * Function parameter should be passed by const reference

[dcb314]

Source code is

friend bool operator==(redecl_iterator x, redecl_iterator y) {
  return x.Current == y.Current;
}
friend bool operator!=(redecl_iterator x, redecl_iterator y) {
  return x.Current != y.Current;
}

Maybe better code:

friend bool operator==( const redecl_iterator & x, const redecl_iterator & y) {
  return x.Current == y.Current;
}
friend bool operator!=( const redecl_iterator & x, const redecl_iterator & y) {
  return x.Current != y.Current;
}

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (dcb314)

Source code is

friend bool operator==(redecl_iterator x, redecl_iterator y) {
  return x.Current == y.Current;
}
friend bool operator!=(redecl_iterator x, redecl_iterator y) {
  return x.Current != y.Current;
}

Maybe better code:

friend bool operator==( const redecl_iterator & x, const redecl_iterator & y) {
  return x.Current == y.Current;
}
friend bool operator!=( const redecl_iterator & x, const redecl_iterator & y) {
  return x.Current != y.Current;
}