Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Remove TEST_VARIANT_HAS_NO_REFERENCES #83600

Closed
ldionne opened this issue Mar 1, 2024 · 0 comments · Fixed by #84222
Closed

[libc++] Remove TEST_VARIANT_HAS_NO_REFERENCES #83600

ldionne opened this issue Mar 1, 2024 · 0 comments · Fixed by #84222
Assignees
@huixie90
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite

Comments

@ldionne
Copy link
Member

ldionne commented Mar 1, 2024

It's not used and std::variant doesn't support references. There might have been plans to support it at some point but clearly that's not the case anymore.
@ldionne ldionne added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 1, 2024
@huixie90 huixie90 mentioned this issue Mar 6, 2024
Merged
ldionne pushed a commit that referenced this issue Mar 26, 2024
@huixie90
[libc++][test] Remove tests that testing std::variant<T&> (#84222)
dfde6e8 
Fixes #83600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huixie90 huixie90

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc++][test] remove tests that testing std::variant<T&> huixie90/llvm-project
3 participants
@ldionne @EugeneZelenko @huixie90