Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang C++20 Feature: P0315R4 - Lambdas in unevaluated contexts #54296

Closed
JVApen opened this issue Mar 9, 2022 · 6 comments
Closed

Clang C++20 Feature: P0315R4 - Lambdas in unevaluated contexts #54296

JVApen opened this issue Mar 9, 2022 · 6 comments
Labels
c++20 clang:frontend Language frontend issues, e.g. anything involving "Sema"

Comments

@JVApen
Copy link

JVApen commented Mar 9, 2022

id: P0315R4
paper: https://wg21.link/p0315r4
partially implemented: status unknown
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 9, 2022

@llvm/issue-subscribers-c-20

@ecnelises
Copy link
Member

Can we rename issue-subscribers-c-20 to issue-subscribers-cpp-20 (or something like that) to avoid confusion?

@EugeneZelenko
Copy link
Contributor

@ecnelises: Please file new issue for that.

@cor3ntin
Copy link
Contributor

This is marked partial because [temp.deduct] p/9 is not implemented
https://eel.is/c++draft/temp.deduct#general-9

https://godbolt.org/z/jPKr6zv7P

@cor3ntin cor3ntin reopened this Mar 25, 2022
@EugeneZelenko EugeneZelenko added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Mar 25, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 25, 2022

@llvm/issue-subscribers-clang-frontend

cor3ntin added a commit that referenced this issue Mar 25, 2022
@cor3ntin
[Clang] Fix error in Documentation introduced by 3784e8c [nfc].
26e201b 
The documentation contained extra space.
Also remove #54296
from the list of issues by 3784e8c as this commit did not
fix it (nor was it supposed to).
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Apr 2, 2022
@cor3ntin @llvmbot
[Clang] Fix Unevaluated Lambdas
df8d4ff 
Unlike other types, when lambdas are instanciated,
they are recreated from scratch.
When an unevaluated lambdas appear in the type of a function,
parameter it is instanciated in the wrong declaration context,
as parameters are transformed before the function.

To support lambda in function parameters, we try to
compute whether they are dependant without looking at the
declaration context.

This is a short term stopgap solution to avoid clang
iceing. A better fix might be to inject some kind of
transparent declaration with correctly computed dependency
for function parameters, variable templates, etc.

Fixes llvm#50376
Fixes llvm#51414
Fixes llvm#51416
Fixes llvm#51641
Fixes llvm#54296

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D121532

(cherry picked from commit 3784e8c)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Apr 2, 2022
@cor3ntin @llvmbot
[Clang] Fix Unevaluated Lambdas
ae01c74 
Unlike other types, when lambdas are instanciated,
they are recreated from scratch.
When an unevaluated lambdas appear in the type of a function,
parameter it is instanciated in the wrong declaration context,
as parameters are transformed before the function.

To support lambda in function parameters, we try to
compute whether they are dependant without looking at the
declaration context.

This is a short term stopgap solution to avoid clang
iceing. A better fix might be to inject some kind of
transparent declaration with correctly computed dependency
for function parameters, variable templates, etc.

Fixes llvm#50376
Fixes llvm#51414
Fixes llvm#51416
Fixes llvm#51641
Fixes llvm#54296

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D121532

(cherry picked from commit 3784e8c)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Apr 2, 2022
@cor3ntin @llvmbot
[Clang] Fix Unevaluated Lambdas
ace080d 
Unlike other types, when lambdas are instanciated,
they are recreated from scratch.
When an unevaluated lambdas appear in the type of a function,
parameter it is instanciated in the wrong declaration context,
as parameters are transformed before the function.

To support lambda in function parameters, we try to
compute whether they are dependant without looking at the
declaration context.

This is a short term stopgap solution to avoid clang
iceing. A better fix might be to inject some kind of
transparent declaration with correctly computed dependency
for function parameters, variable templates, etc.

Fixes llvm#50376
Fixes llvm#51414
Fixes llvm#51416
Fixes llvm#51641
Fixes llvm#54296

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D121532

(cherry picked from commit 3784e8c)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Apr 2, 2022
@cor3ntin @llvmbot
[Clang] Fix Unevaluated Lambdas
f42ae93 
Unlike other types, when lambdas are instanciated,
they are recreated from scratch.
When an unevaluated lambdas appear in the type of a function,
parameter it is instanciated in the wrong declaration context,
as parameters are transformed before the function.

To support lambda in function parameters, we try to
compute whether they are dependant without looking at the
declaration context.

This is a short term stopgap solution to avoid clang
iceing. A better fix might be to inject some kind of
transparent declaration with correctly computed dependency
for function parameters, variable templates, etc.

Fixes llvm#50376
Fixes llvm#51414
Fixes llvm#51416
Fixes llvm#51641
Fixes llvm#54296

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D121532

(cherry picked from commit 3784e8c)
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
@cor3ntin
[Clang] Fix Unevaluated Lambdas
ad45d2a 
Unlike other types, when lambdas are instanciated,
they are recreated from scratch.
When an unevaluated lambdas appear in the type of a function,
parameter it is instanciated in the wrong declaration context,
as parameters are transformed before the function.

To support lambda in function parameters, we try to
compute whether they are dependant without looking at the
declaration context.

This is a short term stopgap solution to avoid clang
iceing. A better fix might be to inject some kind of
transparent declaration with correctly computed dependency
for function parameters, variable templates, etc.

Fixes llvm/llvm-project#50376
Fixes llvm/llvm-project#51414
Fixes llvm/llvm-project#51416
Fixes llvm/llvm-project#51641
Fixes llvm/llvm-project#54296

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D121532
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
@cor3ntin
[Clang] Fix error in Documentation introduced by 3784e8cc [nfc].
1e4c02a 
The documentation contained extra space.
Also remove llvm/llvm-project#54296
from the list of issues by 3784e8cc as this commit did not
fix it (nor was it supposed to).
@cor3ntin
Copy link
Contributor

This is now fully implemented (in clang 17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++20 clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
C++ 20 in Clang
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JVApen @cor3ntin @EugeneZelenko @ecnelises @llvmbot