Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-include-order check inconsistent with clang-format #53525

Closed
sam-mccall opened this issue Feb 1, 2022 · 1 comment
Closed

llvm-include-order check inconsistent with clang-format #53525

sam-mccall opened this issue Feb 1, 2022 · 1 comment
Assignees
@kadircet
Labels
clang-tidy

Comments

@sam-mccall
Copy link
Collaborator

clang-format wants:

#include "aaaaa.h"
#include "zzzzz.h"
#include "gtest/gtest.h"
#include <algorithm>
#include <vector>

(gtest is a group above system headers)

clang-tidy wants:

#include "aaaaa.h"
#include "zzzzz.h"
#include <algorithm>
#include "gtest/gtest.h"
#include <vector>

(gtest is grouped within system headers)

I think this went wrong in 5a9f386
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 1, 2022

@llvm/issue-subscribers-clang-tidy

@kadircet kadircet mentioned this issue Feb 3, 2022
Closed
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 4, 2022
@kadircet @tstellar
[clang-tidy] Fix LLVM include order check policy
d25c765 
Clang-format LLVM style has a custom include category for gtest/ and
gmock/ headers between regular includes and angled includes. Do the same here.

Fixes llvm#53525.

Differential Revision: https://reviews.llvm.org/D118913

(cherry picked from commit 0447ec2)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 5, 2022
@kadircet @llvmbot
[clang-tidy] Fix LLVM include order check policy
fa64174 
Clang-format LLVM style has a custom include category for gtest/ and
gmock/ headers between regular includes and angled includes. Do the same here.

Fixes llvm#53525.

Differential Revision: https://reviews.llvm.org/D118913

(cherry picked from commit 0447ec2)
tstellar pushed a commit that referenced this issue Feb 7, 2022
@kadircet @tstellar
[clang-tidy] Fix LLVM include order check policy
52557b9 
Clang-format LLVM style has a custom include category for gtest/ and
gmock/ headers between regular includes and angled includes. Do the same here.

Fixes #53525.

Differential Revision: https://reviews.llvm.org/D118913

(cherry picked from commit 0447ec2)
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
@kadircet
[clang-tidy] Fix LLVM include order check policy
5644b7b 
Clang-format LLVM style has a custom include category for gtest/ and
gmock/ headers between regular includes and angled includes. Do the same here.

Fixes llvm/llvm-project#53525.

Differential Revision: https://reviews.llvm.org/D118913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadircet kadircet

Labels
clang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sam-mccall @kadircet @llvmbot