Skip to content

Commit

Permalink
[libclc] Disable external-calls testing for clspv targets (#127529)
Browse files Browse the repository at this point in the history
These targets don't include all OpenCL builtins, so there will always be
external calls in the final bytecode module.

Fixes #127316.

(cherry picked from commit 9fec0a0)
  • Loading branch information
frasercrmck authored and tstellar committed Feb 18, 2025
1 parent 34f5f90 commit f567c03
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions libclc/cmake/modules/AddLibclc.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,9 @@ function(add_libclc_builtin_set)
add_custom_target( prepare-${obj_suffix} ALL DEPENDS ${obj_suffix} )
set_target_properties( "prepare-${obj_suffix}" PROPERTIES FOLDER "libclc/Device IR/Prepare" )

# nvptx-- targets don't include workitem builtins
if( NOT ARG_TRIPLE MATCHES ".*ptx.*--$" )
# nvptx-- targets don't include workitem builtins, and clspv targets don't
# include all OpenCL builtins
if( NOT ARG_ARCH MATCHES "^(nvptx|clspv)(64)?$" )
add_test( NAME external-calls-${obj_suffix}
COMMAND ./check_external_calls.sh ${CMAKE_CURRENT_BINARY_DIR}/${obj_suffix} ${LLVM_TOOLS_BINARY_DIR}
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} )
Expand Down

0 comments on commit f567c03

Please sign in to comment.