Skip to content

Commit

Permalink
[ProfileData] Simplify calls to readNext in readBinaryIdsInternal (NF…
Browse files Browse the repository at this point in the history
…C) (#94862)

readNext has two variants:

- readNext<uint64_t, endian>(ptr)
- readNext<uint64_t>(ptr, endian)

This patch uses the latter to simplify readBinaryIdsInternal.  Both
forms default to unaligned.
  • Loading branch information
kazutakahirata authored Jun 8, 2024
1 parent 998c33e commit e62c214
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions llvm/lib/ProfileData/InstrProfReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,7 @@ readBinaryIdsInternal(const MemoryBuffer &DataBuffer,
instrprof_error::malformed,
"not enough data to read binary id length");

uint64_t BILen = 0;
if (Endian == llvm::endianness::little)
BILen = endian::readNext<uint64_t, llvm::endianness::little>(BI);
else
BILen = endian::readNext<uint64_t, llvm::endianness::big>(BI);

uint64_t BILen = endian::readNext<uint64_t>(BI, Endian);
if (BILen == 0)
return make_error<InstrProfError>(instrprof_error::malformed,
"binary id length is 0");
Expand Down

0 comments on commit e62c214

Please sign in to comment.