Skip to content

Commit

Permalink
[mlir] Fully qualify return types in OpAsmInterface.td and FunctionIn…
Browse files Browse the repository at this point in the history
…terfaces.td
  • Loading branch information
zero9178 committed Jan 21, 2022
1 parent 69825f3 commit d03c5bc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions mlir/include/mlir/IR/FunctionInterfaces.td
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface"> {
the type (to allow for this method may be called on function
declarations).
}],
"ArrayRef<Type>", "getArgumentTypes">,
"::llvm::ArrayRef<::mlir::Type>", "getArgumentTypes">,
InterfaceMethod<[{
Returns the function result types based exclusively on
the type (to allow for this method may be called on function
declarations).
}],
"ArrayRef<Type>", "getResultTypes">,
"::llvm::ArrayRef<::mlir::Type>", "getResultTypes">,
InterfaceMethod<[{
Returns a clone of the function type with the given argument and
result types.
Expand All @@ -70,7 +70,7 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface"> {
an appropriate clone method:
`Type clone(ArrayRef<Type> inputs, ArrayRef<Type> results)`
}],
"Type", "cloneTypeWith", (ins
"::mlir::Type", "cloneTypeWith", (ins
"::mlir::TypeRange":$inputs, "::mlir::TypeRange":$results
), /*methodBody=*/[{}], /*defaultImplementation=*/[{
return $_op.getType().clone(inputs, results);
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/IR/OpAsmInterface.td
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def OpAsmOpInterface : OpInterface<"OpAsmOpInterface"> {
returned `spv`. The default implementation returns an empty string which
is ignored.
}],
"StringRef", "getDefaultDialect", (ins), "", "return \"\";"
"::llvm::StringRef", "getDefaultDialect", (ins), "", "return \"\";"
>,
];
}
Expand Down

0 comments on commit d03c5bc

Please sign in to comment.