Skip to content

Commit

Permalink
[DAGCombiner] Replace LegalOperations check in visitSIGN_EXTEND with …
Browse files Browse the repository at this point in the history
…LegalTypes.

This is guarding a check for isTypeLegal so it should check is
LegalTypes.

Fixes PR61111.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D145139

(cherry picked from commit c546f13)
  • Loading branch information
topperc authored and tru committed Mar 6, 2023
1 parent 29a7dbb commit 076ceb7
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
3 changes: 2 additions & 1 deletion llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12454,7 +12454,8 @@ SDValue DAGCombiner::visitSIGN_EXTEND(SDNode *N) {
if (N0.getOpcode() == ISD::SIGN_EXTEND_INREG) {
SDValue N00 = N0.getOperand(0);
EVT ExtVT = cast<VTSDNode>(N0->getOperand(1))->getVT();
if (N00.getOpcode() == ISD::TRUNCATE && (!LegalOperations || TLI.isTypeLegal(ExtVT))) {
if (N00.getOpcode() == ISD::TRUNCATE &&
(!LegalTypes || TLI.isTypeLegal(ExtVT))) {
SDValue T = DAG.getNode(ISD::TRUNCATE, DL, ExtVT, N00.getOperand(0));
return DAG.getNode(ISD::SIGN_EXTEND, DL, VT, T);
}
Expand Down
25 changes: 25 additions & 0 deletions llvm/test/CodeGen/AArch64/pr61111.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=aarch64-linux-gnu | FileCheck %s

define i62 @f(i1 %0) {
; CHECK-LABEL: f:
; CHECK: // %bb.0:
; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0
; CHECK-NEXT: and x8, x0, #0x1
; CHECK-NEXT: sub x8, x8, #1
; CHECK-NEXT: tst x8, #0x3fffffffffffffff
; CHECK-NEXT: cset w0, ne
; CHECK-NEXT: ret
%2 = zext i1 %0 to i59
%3 = call { i59, i1 } @llvm.umul.with.overflow.i59(i59 %2, i59 -1)
%4 = extractvalue { i59, i1 } %3, 0
%5 = trunc i59 %4 to i21
%6 = trunc i59 %4 to i21
%7 = ashr i21 %5, %6
%8 = sext i21 %7 to i62
%9 = icmp ugt i62 -1, %8
%10 = zext i1 %9 to i62
ret i62 %10
}

declare { i59, i1 } @llvm.umul.with.overflow.i59(i59, i59)

0 comments on commit 076ceb7

Please sign in to comment.