Skip to content

PR for llvm/llvm-project#65620 #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023
Merged

PR for llvm/llvm-project#65620 #702

merged 1 commit into from
Oct 3, 2023

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Sep 20, 2023

@tru
Copy link
Contributor

tru commented Sep 28, 2023

@ldionne @mordante not sure what's up with the tests not really running here. should this be merged?

@ldionne
Copy link
Member

ldionne commented Sep 29, 2023

Yeah, I think this should be merged. However, it looks like our release testing setup is kind of broken.

…on (#66585)

The helper function `__pair_like_explicit_wknd` is only SFINAE-ed with
`tuple_size<remove_cvref_t<_PairLike>>::value == 2`, but its function
body assumes `std::get` being valid.

Fixes #65620

(cherry picked from commit 054f9c55c6b4520d3feb8b4354b9b942026b5124)
@tru
Copy link
Contributor

tru commented Oct 2, 2023

@tstellar any idea why the github checks aren't running on this PR?

@tstellar
Copy link
Contributor

tstellar commented Oct 2, 2023

@tru The tests only run when the lld/ llvm/ clang/ lldb/ libclc/ directories are changed.

@tru
Copy link
Contributor

tru commented Oct 2, 2023

@tru The tests only run when the lld/ llvm/ clang/ lldb/ libclc/ directories are changed.

Aha, but isn't that a problem for libc++ then? we probably should run the libc++ tests as well.

@ldionne do you feel comfortable merging this anyway now? (wonder why we never seen this before?).

@ldionne
Copy link
Member

ldionne commented Oct 2, 2023

Yes, I am. I'll need to spend some time reworking our CI triggering since we have other issues anyway.

@tru tru merged commit 23988a1 into release/17.x Oct 3, 2023
@tru tru deleted the llvm-issue65620 branch October 3, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libc++ makes wrong assumptions in std::pair constructor
5 participants