Skip to content

[CIR][CIRGen][Builtin][Neon] Lower vcalts_f32 #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower vcalts_f32 #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/CIR/CodeGen/CIRGenBuiltinAArch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2712,11 +2712,10 @@ static mlir::Value emitCommonNeonSISDBuiltinExpr(
case NEON::BI__builtin_neon_vcaled_f64:
return emitNeonCall(builder, {argTy}, ops, "aarch64.neon.facge", resultTy,
loc);
case NEON::BI__builtin_neon_vcalts_f32:
case NEON::BI__builtin_neon_vcaltd_f64:
return emitNeonCall(builder, {argTy}, ops, "aarch64.neon.facgt", resultTy,
loc);
case NEON::BI__builtin_neon_vcalts_f32:
llvm_unreachable(" neon_vcalts_f32 NYI ");
case NEON::BI__builtin_neon_vcvtad_s64_f64:
llvm_unreachable(" neon_vcvtad_s64_f64 NYI ");
case NEON::BI__builtin_neon_vcvtad_u64_f64:
Expand Down
13 changes: 10 additions & 3 deletions clang/test/CIR/CodeGen/AArch64/neon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15181,9 +15181,16 @@ uint64_t test_vcaled_f64(float64_t a, float64_t b) {
// NYI-LABEL: @test_vcalts_f32(
// NYI: [[VCALTS_F32_I:%.*]] = call i32 @llvm.aarch64.neon.facgt.i32.f32(float %b, float %a)
// NYI: ret i32 [[VCALTS_F32_I]]
// uint32_t test_vcalts_f32(float32_t a, float32_t b) {
// return (uint32_t)vcalts_f32(a, b);
// }
uint32_t test_vcalts_f32(float32_t a, float32_t b) {
return (uint32_t)vcalts_f32(a, b);

// CIR-LABEL: vcalts_f32
// CIR: [[TMP0:%.*]] = cir.llvm.intrinsic "aarch64.neon.facgt" {{.*}}, {{.*}} : (!cir.float, !cir.float) -> !u32i

// LLVM-LABEL: @test_vcalts_f32(
// LLVM: [[VCALTS_F32_I:%.*]] = call i32 @llvm.aarch64.neon.facgt.i32.f32(float %0, float %1)
// LLVM: ret i32 [[VCALTS_F32_I]]
}

uint64_t test_vcaltd_f64(float64_t a, float64_t b) {
return (uint64_t)vcaltd_f64(a, b);
Expand Down
Loading