Skip to content

[CIR][CUDA] Fix address space values for NVPTX #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

[CIR][CUDA] Fix address space values for NVPTX #1445

merged 2 commits into from
Mar 11, 2025

Conversation

anominos
Copy link
Contributor

@anominos anominos commented Mar 6, 2025

Based on

clangir/clang/lib/Basic/Targets/NVPTX.h

Line 27 in 7f66a20

static const unsigned NVPTXAddrSpaceMap[] = {
, the current address space values are incorrect. This PR fixes these values.

@anominos anominos changed the title Fix address space values for NVPTX [CIR][CUDA] Fix address space values for NVPTX Mar 6, 2025
@anominos anominos mentioned this pull request Mar 6, 2025
Merged
bcardosolopes
bcardosolopes requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Please also add a testcase

@anominos
Copy link
Contributor Author

anominos commented Mar 7, 2025

Nice catch! Please also add a testcase

Added tests, the __constant__ test will be enabled in #1444

@bcardosolopes bcardosolopes merged commit f59cdbb into llvm:main Mar 11, 2025
6 checks passed
bcardosolopes pushed a commit that referenced this pull request Mar 11, 2025
@anominos
[CIR][CUDA] implement cuda constant variables (#1444)
75914ec 
This PR implements \_\_constant\_\_ variables.

#1438 only implements \_\_device\_\_ and \_\_shared\_\_ variables, 

~~This PR depends on #1445~~
lanza pushed a commit that referenced this pull request Mar 18, 2025
@anominos @lanza
[CIR][CUDA] Fix address space values for NVPTX (#1445)
5e50b7e 
Based on
https://github.com/llvm/clangir/blob/7f66a204c4ba1f674cfe0e16e2c9c6b65ca70bc8/clang/lib/Basic/Targets/NVPTX.h#L27,
the current address space values are incorrect. This PR fixes these
values.
lanza pushed a commit that referenced this pull request Mar 18, 2025
@anominos @lanza
[CIR][CUDA] implement cuda constant variables (#1444)
3b62a12 
This PR implements \_\_constant\_\_ variables.

#1438 only implements \_\_device\_\_ and \_\_shared\_\_ variables, 

~~This PR depends on #1445~~
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
@anominos @lanza
[CIR][CUDA] Fix address space values for NVPTX (llvm#1445)
98a3150 
Based on
https://github.com/llvm/clangir/blob/7f66a204c4ba1f674cfe0e16e2c9c6b65ca70bc8/clang/lib/Basic/Targets/NVPTX.h#L27,
the current address space values are incorrect. This PR fixes these
values.
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
@anominos @lanza
[CIR][CUDA] implement cuda constant variables (llvm#1444)
ec98d66 
This PR implements \_\_constant\_\_ variables.

llvm#1438 only implements \_\_device\_\_ and \_\_shared\_\_ variables, 

~~This PR depends on llvm#1445~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anominos @bcardosolopes