Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen][Builtin][Neon] Lower neon_vshr_n_v and neon_vshrq_n_v #1045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Nov 1, 2024

Note in the test file, test_vshrq_n_s32_32 and test_vshr_n_u16_16 are addition to what traditional clang code gen already has.
They tested the case where shift amount is the same as element size ( compiler errors if shift amount is greater than elem size). OG didn't test that case here, but has somewhat tested elsewhere

@ghehg ghehg marked this pull request as ready for review November 1, 2024 17:56
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants