[PyCDE] Add fork, join, and merge channel functions #8011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
frontends/PyCDE/src/pycde/types.py:601
- [nitpick] The parameter name 'validOrEmpty' is unclear. Consider renaming it to 'valid_or_empty' for better readability.
validOrEmpty) -> typing.Tuple["ChannelSignal", "BitsSignal"]:
frontends/PyCDE/src/pycde/signals.py:765
- The
valid_gatesignal should be assigned before theunwrapmethod to ensure thatboth_readyis properly initialized before being used.
valid_gate = both_ready & valid
mortbopet
approved these changes
Dec 19, 2024
- <ChannelSignal>.fork creates two new channels, waits until they are both available, then accepts an input. Also buffer the output channels to avoid combinational loops. - Channel.join waits on two channels then creates a message on the one output channel containing a struct with field 'a' equal to input channel A's content and likewise for channel B. - Channel.merge funnels two channels together into a single output stream. This is functionality which really should be handled by the DC dialect but it's not ready for primetime.
teqdruid
force-pushed
the
teqdruid/pycde/esi-advanced
branch
from
411d6fe to
de995b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is functionality which really should be handled by the DC dialect but it's not ready for primetime.