-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore user from gitlint #52
Comments
@paulodamaso I think this just encourages bad practices from the ARC and PO. I had previously warned Yegor against this - see yegor256/cactoos#1148 Nevertheless I'll look into this and will let you know. |
@llorllale I agree. But i'm having a great problem in cactoos due the commit that puts me as architect: the commit does not follow lint rules, but it was merged anyways. Fact is, we can't stop ARC, PO and whoever who has write permission to a repository to make direct commits. And these commits are messing with future commits. I think these rules should be enforced BEFORE the commit enters the repo, and not after, as it does checking the commit logs. One way to avoid all this problems could be to do not check ARC and PO commits, specially because sometimes these roles can be tempted to make commmits for quick fixes. |
@paulodamaso do you wish to match by the author's name or their email? Are you looking for exact matches or would you rather match against patterns? |
Another way is to make the master branch read-only. Yegor's words: https://www.yegor256.com/2014/07/21/read-only-master-branch.html. This is a simple configuration in the project's settings - all it takes is a click on a checkbox. Enforcing these rules before merging to But if some people don't wish to follow procedure... |
@paulodamaso I released Let me know. |
@llorllale thank you very much, I'll make some tests and tell you |
@paulodamaso closing this - please open a new issue in the future for any followup |
We should be able to ignore users from gitlink, to avoid problems when
ARC
or even rultor needs make a commit to repository.The text was updated successfully, but these errors were encountered: