Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore user from gitlint #52

Closed
paulodamaso opened this issue Sep 13, 2019 · 7 comments
Closed

Ignore user from gitlint #52

paulodamaso opened this issue Sep 13, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@paulodamaso
Copy link

We should be able to ignore users from gitlink, to avoid problems when ARC or even rultor needs make a commit to repository.

@llorllale
Copy link
Owner

@paulodamaso I think this just encourages bad practices from the ARC and PO. I had previously warned Yegor against this - see yegor256/cactoos#1148

Nevertheless I'll look into this and will let you know.

@llorllale llorllale added the enhancement New feature or request label Sep 13, 2019
@llorllale llorllale added this to the 1.1.0 milestone Sep 13, 2019
@llorllale llorllale self-assigned this Sep 13, 2019
@paulodamaso
Copy link
Author

@llorllale I agree. But i'm having a great problem in cactoos due the commit that puts me as architect: the commit does not follow lint rules, but it was merged anyways. Fact is, we can't stop ARC, PO and whoever who has write permission to a repository to make direct commits. And these commits are messing with future commits. I think these rules should be enforced BEFORE the commit enters the repo, and not after, as it does checking the commit logs.

One way to avoid all this problems could be to do not check ARC and PO commits, specially because sometimes these roles can be tempted to make commmits for quick fixes.

@llorllale
Copy link
Owner

@paulodamaso do you wish to match by the author's name or their email? Are you looking for exact matches or would you rather match against patterns?

@llorllale
Copy link
Owner

@paulodamaso

One way to avoid all this problems could be to do not check ARC and PO commits, specially because sometimes these roles can be tempted to make commmits for quick fixes.

Another way is to make the master branch read-only. Yegor's words: https://www.yegor256.com/2014/07/21/read-only-master-branch.html. This is a simple configuration in the project's settings - all it takes is a click on a checkbox. Enforcing these rules before merging to master is then a simple matter of raising a PR.

But if some people don't wish to follow procedure... ¯\_(ツ)_/¯

@llorllale
Copy link
Owner

@paulodamaso I released 1.1.0 with two new flags excl-author-names and excl-author-emails. Both are comma-separated lists of regular expressions that you can use to exclude authors by name or email.

Let me know.

@paulodamaso
Copy link
Author

@llorllale thank you very much, I'll make some tests and tell you

@llorllale
Copy link
Owner

@paulodamaso closing this - please open a new issue in the future for any followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants