Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsNumber matcher #207

Closed
andreoss opened this issue Nov 1, 2020 · 9 comments
Closed

IsNumber matcher #207

andreoss opened this issue Nov 1, 2020 · 9 comments

Comments

@andreoss
Copy link
Contributor

andreoss commented Nov 1, 2020

There are several classes in cactoos that extend Number (LengthOf, DivisionOf, AvgOf, SumOf, NumberOf, NumberEnvelope, MultiplicationOf, MaxOf, MinOf, Sealed).

Let's introduce IsNumber in order to test them with avoiding calling intValue(), longValue(), etc on these objects.

@0crat 0crat added the 0crat/new label Nov 1, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 5, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 5, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 5, 2020
@victornoel
Copy link
Collaborator

@0crat assign @andreoss

andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 14, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 14, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Nov 15, 2020
@victornoel
Copy link
Collaborator

@andreoss I see some commits associated to this ticket, but no PR, did you forget to create it?

@andreoss
Copy link
Contributor Author

@victornoel It was merged already #208

@victornoel
Copy link
Collaborator

@andreoss ah perfect, next time can you close or ping the bug reporter (or ARC) for the issue to be closed once an issue is fixed? :)

@victornoel
Copy link
Collaborator

@andreoss also don't hesitate to create an issue in cactoos for starting using this new matcher in the tests then!

@0crat 0crat added qa and removed 0crat/scope labels Dec 27, 2020
@0crat
Copy link
Collaborator

0crat commented Dec 27, 2020

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@victornoel please make sure problem reported and problem solvers are 2 different persons

@victornoel
Copy link
Collaborator

@sereshqua yes, we are a bit short in active DEVs but nevertheless, I will try do to so in the future :)

@sereshqua
Copy link

@0crat quality acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants