Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TextMatcher to take a Matcher<String> #203

Closed
victornoel opened this issue Sep 27, 2020 · 5 comments
Closed

Simplify TextMatcher to take a Matcher<String> #203

victornoel opened this issue Sep 27, 2020 · 5 comments
Assignees
@victornoel
Labels
0crat/role/DEV

Comments

@victornoel
Copy link
Collaborator

victornoel commented Sep 27, 2020 •
edited
Loading

Since TextMatcher is meant to work at a lower level of abstraction than the Matcher<Text> class it implements, let's make it take a Matcher<String> instead of a Matcher<Text>.

This will simplify code, behaviour and shouldn't introduce regression.
@victornoel
Copy link
Collaborator Author

@0crat assign me

victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify TextMatcher
068ec63
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify Assertion to ease debug
1d308b1
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify TextMatcher
f26f6b6
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify Assertion to ease debug
4ec4621
@victornoel victornoel mentioned this issue Sep 27, 2020
Merged
@victornoel
Copy link
Collaborator Author

@0crat wait for #204

@0crat 0crat added the waiting label Sep 27, 2020
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify TextMatcher
d79de22
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Sep 27, 2020
@victornoel
(llorllale#203) Simplify Assertion to ease debug
f834f8c
@0crat 0crat removed the waiting label Sep 29, 2020
@0crat
Copy link
Collaborator

0crat commented Sep 29, 2020

Job was finished in 47 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the 0crat/scope label Sep 29, 2020
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Feb 13, 2021
@victornoel
(llorllale#203) Improve TextMatcher API and messages
8584b6b
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Feb 13, 2021
@victornoel
(llorllale#203) Improve TextMatcher API and messages
65655bc
@victornoel victornoel mentioned this issue Feb 13, 2021
Merged
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Feb 13, 2021
@victornoel
(llorllale#203) Improve TextMatcher API and messages
f35165c
victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Feb 13, 2021
@victornoel
(llorllale#203) Improve TextMatcher API and messages
ae8c090
@victornoel
Copy link
Collaborator Author

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 10, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victornoel victornoel

Labels
0crat/role/DEV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@victornoel @0crat