Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:162-169: This plugin execution was disabled... #202

Closed
0pdd opened this issue Sep 27, 2020 · 27 comments
Closed

pom.xml:162-169: This plugin execution was disabled... #202

0pdd opened this issue Sep 27, 2020 · 27 comments
Labels
Milestone

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 27, 2020

The puzzle 159-5a01dc84 from #159 has to be resolved:

cactoos-matchers/pom.xml

Lines 162 to 169 in c5404b8

@todo #159:30min This plugin execution was disabled
(phase was set to `package` before) because it prevents
cactoos from actually using cactoos-matchers since the
interfaces provided by cactoos (`Text`, `Func`, `Scalar`, etc)
and those expected by cactoos-matchers do no match!
Let's find a solution to this situation (not shading the
interfaces for example?) and re-enable this plugin. The best
solution should be discussed with ARC in this todo's ticket.

The puzzle was created by Victor Noël on 27-Sep-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Sep 27, 2020

This puzzle inherited milestone 1.0.0 from issue #159.

@victornoel
Copy link
Collaborator

@0crat status

@victornoel victornoel added this to the 1.0.0 milestone Oct 11, 2020
@victornoel
Copy link
Collaborator

@0crat in

@victornoel victornoel added bug Something isn't working pdd labels Oct 11, 2020
@0crat
Copy link
Collaborator

0crat commented Oct 11, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@0crat
Copy link
Collaborator

0crat commented Oct 11, 2020

@0crat in (here)

@victornoel Job #202 is already in scope

@victornoel
Copy link
Collaborator

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jan 15, 2021

@0crat refuse (here)

@victornoel The user @fabriciofx/z resigned from #202, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2021

The job #202 assigned to @baudoliver7/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@baudoliver7
Copy link
Contributor

@victornoel Let's please discuss about this plugin and the problem in question

@victornoel
Copy link
Collaborator

@baudoliver7 yes, this is not an easy problem. Basically the original need was introduced in #159. If you have ideas to solve this problem, either using the shade plugin or something else, we can discuss it here: this is more a design job than a programming job. If we find a good idea, we will add a new todo.

Alternatively, do not forget you can also refuse jobs if you don't want to do them.

@baudoliver7
Copy link
Contributor

@victornoel This task seems very interesting ! I will try to resolve it :)

@baudoliver7
Copy link
Contributor

@victornoel This ticket is assigned to me but doesn't appear in my agenda. Curious :)

@victornoel
Copy link
Collaborator

@0crat status

@victornoel
Copy link
Collaborator

@baudoliver7 you can try raising an issue at zerocracy/farm but I would expect you to get ignored there ^^

@0crat
Copy link
Collaborator

0crat commented Jan 31, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@baudoliver7
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Feb 3, 2021

@0crat status (here)

@baudoliver7 This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator

@baudoliver7 how is it going with this? I was thinking (if that's possible) that the maven shade plugin could shade everything BUT the interfaces. Then it should be ok.

@victornoel
Copy link
Collaborator

@baudoliver7 it seems to be possible with:

              <relocations>
                <relocation>
                  <pattern>org.cactoos</pattern>
                  <shadedPattern>org.llorllale.cactoos.shaded.org.cactoos</shadedPattern>
                  <excludes>
                    <exclude>org.cactoos.*</exclude>
                  </excludes>
                </relocation>
              </relocations>

@victornoel
Copy link
Collaborator

@baudoliver7 btw even if it doesn't appear in the agenda, it's really assigned to you and you will get the points :)

@baudoliver7
Copy link
Contributor

@baudoliver7 how is it going with this? I was thinking (if that's possible) that the maven shade plugin could shade everything BUT the interfaces. Then it should be ok.

@victornoel I think it's the solution. I will try this.

baudoliver7 pushed a commit to baudoliver7/cactoos-matchers that referenced this issue Feb 6, 2021
@victornoel
Copy link
Collaborator

@baudoliver7 not sure why 0pdd didn't close it itself, so I do it manually, don't hesitate in the future to ask if you need tickets to be closed when the job is done :)

@baudoliver7
Copy link
Contributor

@victornoel Got it. Thx :)

@0crat 0crat added the qa label Feb 22, 2021
@0crat
Copy link
Collaborator

0crat commented Feb 22, 2021

Job #202 is not in the agenda of @baudoliver7/z, can't set title

@0crat
Copy link
Collaborator

0crat commented Feb 22, 2021

Job #202 is not in the agenda of @baudoliver7/z, can't set title

@0crat
Copy link
Collaborator

0crat commented Feb 22, 2021

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the 0crat/scope label Feb 22, 2021
@sereshqua
Copy link

@0crat quality good

@0crat 0crat added quality/good and removed qa labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants