Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:78-81: Migrate existing tests to JUnit 5. It... #170

Closed
0pdd opened this issue Sep 7, 2020 · 4 comments
Closed

pom.xml:78-81: Migrate existing tests to JUnit 5. It... #170

0pdd opened this issue Sep 7, 2020 · 4 comments
Labels

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 7, 2020

The puzzle 162-6ab83915 from #162 has to be resolved:

cactoos-matchers/pom.xml

Lines 78 to 81 in 310fd52

@todo #162:30min Migrate existing tests to JUnit 5. It mainly means
changing the imports and move from Ignore to Disabled annotation as
well as replace rules with corresponding annotations. Once this is done
remove the dependency for junit 4 and junit-vintage-engine below.

The puzzle was created by Victor Noël on 07-Sep-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 0pdd added bug Something isn't working pdd labels Sep 7, 2020
@0crat 0crat added the 0crat/new label Sep 7, 2020
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Jan 12, 2021
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Jan 12, 2021
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Jan 12, 2021
andreoss added a commit to andreoss/cactoos-matchers that referenced this issue Jan 14, 2021
@0pdd 0pdd closed this as completed Jan 14, 2021
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 14, 2021

The puzzle 162-6ab83915 has disappeared from the source code, that's why I closed this issue.

@0crat 0crat added the qa label Jan 14, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 14, 2021

@sereshqua/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the 0crat/scope label Jan 14, 2021
@sereshqua
Copy link

@0crat quality bad

@0crat 0crat added quality/bad and removed qa labels Jan 14, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 14, 2021

Quality is low, no payment, see §31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants