TextMatcherEnvelope should call asString() only once at all

[victornoel]

All the Matcher<Text> that relies on TextMatcherEnvelope suffers from having asString() being called multiple times.

In some case it can be a problem, for example when a Text is based on an InputStream that can be read only once. See for example yegor256/cactoos#1145 (comment)

I believe TextMatcherEnvelope should wraps text into some kind of Sticky decorator to avoid any problem.

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@victornoel funny - I was just reading this today. I'm closing this issue and deferring this conversation for later. I'll accept your PR in yegor256/cactoos#1145 as is

[0crat]

Job gh:llorllale/cactoos-matchers#132 is not assigned, can't get performer

[0crat]

This job is not in scope

[victornoel]

@llorllale I've read it too, I don't agree with the content personally. That being said, I don't think this issue is about caching or not caching, it is just about having a consistent behaviour of Text matchers, whatever the mean used to solve the problem.

[llorllale]

@victornoel what do you propose? Wrap it in Sticky in TextMatcherEnvelope#matchesSafely()?

[victornoel]

@llorllale I would have done something like that yes I think

[llorllale]

@0crat in

[0crat]

@llorllale/z please, pay attention to this issue

[0crat]

@0crat in (here)

@llorllale Job #132 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

[0crat]

The job #132 assigned to @umbrah/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[0crat]

The architect of the project has changed; @llorllale/z is not at this role anymore; @paulodamaso/z is the architect now

[victornoel]

@paulodamaso I'm blocked by this to solve other issues in cactoos, the fix is quite simple, can this be proactively assigned to somebody and a release made if possible?

[paulodamaso]

@victornoel Can you do it for us?

[victornoel]

@paulodamaso yes

[paulodamaso]

@0crat assign @victornoel

[paulodamaso]

@victornoel Thanks!

[0crat]

@0crat assign @victornoel (here)

@paulodamaso The job #132 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[0crat]

@0crat assign @victornoel (here)

@paulodamaso There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@da69ffec-8968-43a0-8327-1386ee9c8dff, thread: pool-26-thread-2
com.zerocracy.claims.ClaimIn[198] java.lang.IllegalArgumentException: Parameter "age" not found in "Order was canceled" among: [comment, job, issue, repo, cause, _parent_sig, flow, login]

0.49.12: CID: 83a83d7a-f893-4ce9-9d24-3d070b7eb495, Type: "Order was canceled"

[0crat]

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

[0crat]

It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @paulodamaso/z

[victornoel]

@0crat wait for #147

[0crat]

@0crat wait for #147 (here)

@victornoel The impediment for #132 was registered successfully by @victornoel/z

[victornoel]

@paulodamaso can we get a new release of cactoos-matchers now that this has been merged?

[0crat]

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #132 is now out of scope

[sereshqua]

@victornoel we will need to make sure that problem reporter and problem solver are two different persons next time

[victornoel]

@sereshqua yes I agree

[sereshqua]

@0crat quality acceptable

[0crat]

Quality review completed: +4 point(s) just awarded to @sereshqua/z

[0crat]

Order was finished, quality is "acceptable": +30 point(s) just awarded to @victornoel/z

[paulodamaso]

@

@paulodamaso can we get a new release of cactoos-matchers now that this has been merged?

@victornoel of course

[paulodamaso]

@rultor release tag is 0.18

[rultor]

@rultor release tag is 0.18

@paulodamaso OK, I will release it now. Please check the progress here

[rultor]

@rultor release tag is 0.18

@paulodamaso Done! FYI, the full log is here (took me 11min)

[victornoel]

@paulodamaso thx