Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws do not support null as message #119

Closed
vladhss opened this issue Apr 29, 2019 · 28 comments
Closed

Throws do not support null as message #119

vladhss opened this issue Apr 29, 2019 · 28 comments

Comments

@vladhss
Copy link

vladhss commented Apr 29, 2019

I want to verify NullPointerException is thrown, but org.llorllale.cactoos.matchers.Throws fails when I use null as msg parameter. I want to be able to use it or have another constructor only with exception param.

@0crat
Copy link
Collaborator

0crat commented Apr 29, 2019

@llorllale/z please, pay attention to this issue

@ilyakharlamov
Copy link

Unit test example: `

@test
public void nullMessageTest(){
    final Description description = new StringDescription();
    new Throws<>(null, NullPointerException.class).matchesSafely(
        () -> {
            final Object obj = null;
            return obj.getClass();
        },
        description
    );
}`

@llorllale
Copy link
Owner

@0crat in

@llorllale
Copy link
Owner

@Umbrah let's add a ctor that takes in just the exception type

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2019

@0crat in (here)

@llorllale Job #119 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2019

Bug was reported, see §29: +15 point(s) just awarded to @umbrah/z

@0crat
Copy link
Collaborator

0crat commented May 30, 2019

The job #119 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@0crat wait for #126 to be merged

@0crat
Copy link
Collaborator

0crat commented May 30, 2019

@0crat wait for #126 to be merged (here)

@victornoel The impediment for #119 was registered successfully by @victornoel/z

victornoel added a commit to victornoel/cactoos-matchers that referenced this issue May 30, 2019
@victornoel
Copy link
Collaborator

@Umbrah this has been fixed in #126, the issue can now be closed :)

@victornoel
Copy link
Collaborator

@llorllale the reporter does not seem to answer, can we close this?

@victornoel
Copy link
Collaborator

@llorllale @Umbrah ping

@llorllale
Copy link
Owner

@umbrah closing due to unresponsiveness (PR #126 merged for this)

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

Job #119 is not in the agenda of @victornoel/z, can't inspect

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

The job #119 is now out of scope

@g4s8
Copy link

g4s8 commented Jun 7, 2019

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

@0crat status (here)

@g4s8 This is what I know about this job in C63314D6Z, as in §32:

@sereshqua
Copy link

@ilyakharlamov can you please edit your comment that it start with the user'w name it is referred to? otherwise quality is acceptable here

@victornoel
Copy link
Collaborator

@sereshqua I don't think @ilyakharlamov is here anymore with us.

@sereshqua
Copy link

@victornoel, yeap, just a matter of policy, so issue performer knows why quality is not good

@victornoel
Copy link
Collaborator

@sereshqua I understand, but you never told 0crat about the quality in the end ;)

@sereshqua
Copy link

sereshqua commented Jun 8, 2019

@0cat quality acceptable

@0pdd
Copy link
Collaborator

0pdd commented Jun 8, 2019

@0pdd quality acceptable

I see you're talking to me, but I can't reply since I'm not a chat bot.

@sereshqua
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Jun 8, 2019

Order was finished, quality is "acceptable": +30 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Jun 8, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@g4s8
Copy link

g4s8 commented Sep 16, 2019

@0crat status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants