Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose dlv's --backend arg in config #137

Merged

Conversation

khalilovcmd
Copy link
Contributor

@khalilovcmd khalilovcmd commented May 1, 2018

https://github.com/derekparker/delve/issues/817

There seems to be an issue using lldb as a debugger option. I was able to resolve the issue by changing it to --backend=native. To allow more flexibility and unblock atom go-debug users who are experiencing this issue, I suggest that we expose the --backend in config while maintaing a default value of --backend=default.

  • Tested locally
  • Ran it with expected + unexpected args

https://github.com/derekparker/delve/issues/817

There seems to be an issue using `lldb` as a debugger option. I was able to resolve the issue by changing it to `--backend=native`. To allow more flexibility and unblock atom go-debug users who are experiencing this issue, I suggest that we expose the `--backend` in config while maintaing a default value of `--backend=default`.
@khalilovcmd
Copy link
Contributor Author

@lloiser does this change make sense or do you have other ideas? (or perhaps I missed a way to pass --backend in the config?)

@lloiser
Copy link
Owner

lloiser commented May 1, 2018

Thx for adding this! No it's okay to add it, I just refrained because I never encountered problems with the default backend.
LGTM

@lloiser lloiser merged commit 207124b into lloiser:master May 1, 2018
@lloiser
Copy link
Owner

lloiser commented May 1, 2018

Aaaand it's out in 1.6.2 😁

@khalilovcmd
Copy link
Contributor Author

@lloiser nice one! Thanks 😄

@khalilovcmd khalilovcmd deleted the tarek/expose-dlv-backend-arg-in-config branch May 2, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants