Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp fix for preprocessor_revision.py #1860

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

Melyns
Copy link
Contributor

@Melyns Melyns commented Sep 18, 2024

This is a temporary fix for the bug with controlnet revision ControlNet AttributeError: 'KModel' object has no attribute 'noise_augmentor'. #1420

I added a function that checks if the noise_augmentor attribute is present. If it is not, it prints a warning message and skips the noise augmentation step. Revision mode can still proceed even if the noise_augmentor attribute error occurs. I hid the Noise Augmentation slider since this fix disables that step.

@Melyns Melyns requested a review from lllyasviel as a code owner September 18, 2024 16:36
@DenOfEquity
Copy link
Collaborator

Good work.
I'd not bother with the warning/error message - any user that reads it can't do anything about it anyway, and it messes up the progress display. Then the initial check could be replaced with noise_augmentor = getattr(model, 'noise_augmentor', None).

@Melyns
Copy link
Contributor Author

Melyns commented Sep 18, 2024

Good work. I'd not bother with the warning/error message - any user that reads it can't do anything about it anyway, and it messes up the progress display. Then the initial check could be replaced with noise_augmentor = getattr(model, 'noise_augmentor', None).

thank you, great suggestion. i applied what you have recommended, its much better now.

@DenOfEquity DenOfEquity merged commit b20cb4b into lllyasviel:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants