Skip to content

Commit

Permalink
enables spilling
Browse files Browse the repository at this point in the history
  • Loading branch information
lll-phill-lll committed May 30, 2024
1 parent 60e1b89 commit d1a6793
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ydb/library/yql/minikql/aligned_page_pool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ void TAlignedPagePoolImpl<T>::Free(void* ptr, size_t size) noexcept {
template<typename T>
void TAlignedPagePoolImpl<T>::UpdateMemoryYellowZone() {
if (Limit == 0) return;
if (IncreaseMemoryLimitCallback && !IsMaximumLimitValueReached) return;
// if (IncreaseMemoryLimitCallback && !IsMaximumLimitValueReached) return;

ui8 usedMemoryPercent = 100 * GetUsed() / Limit;
if (usedMemoryPercent >= EnableMemoryYellowZoneThreshold) {
Expand Down
4 changes: 2 additions & 2 deletions ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -631,9 +631,9 @@ class TGraceJoinSpillingSupportState : public TComputationValue<TGraceJoinSpilli
}

bool IsSwitchToSpillingModeCondition() const {
return false;
// return false;
// TODO: YQL-18033
// return !HasMemoryForProcessing();
return !HasMemoryForProcessing();
}

void SwitchMode(EOperatingMode mode, TComputationContext& ctx) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace NYql::NDqs {
NDq::NTaskRunnerActor::ITaskRunnerActorFactory::TPtr TaskRunnerActorFactory;
THashMap<TString, TString> ClusterNamesMapping;

ui64 MkqlInitialMemoryLimit = 8_GB;
ui64 MkqlInitialMemoryLimit = 50_MB;
ui64 MkqlTotalMemoryLimit = 0;
ui64 MkqlMinAllocSize = 30_MB;
ui64 MkqlProgramHardMemoryLimit = 0;
Expand Down

0 comments on commit d1a6793

Please sign in to comment.