Fix passing long environment variables to the debugger #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylatuya
force-pushed
the
fix-set-long-env
branch
from
9357d90
to
3f3c22b
Compare
ylatuya
changed the title
SpaceIm
reviewed
Dec 8, 2021
ylatuya
force-pushed
the
fix-set-long-env
branch
from
3f3c22b
to
b82a491
Compare
You might want to update PR description because that's not what the code does any more. Much better to use std::string than hardcoding a size indeed. |
Replace the command buffer with a std::string to support reading arbitrary command line lengths. This is required in projects like GStreamer that setup long environment variables like GST_PLUGIN_PATH with several directories on it. microsoft/vscode-cpptools#8411 microsoft/vscode-cpptools#6874
ylatuya
force-pushed
the
fix-set-long-env
branch
from
b82a491
to
5662dd1
Compare
|
Any other opinions? If not, I think we can merge it :) |
|
If there are no new opinions, I will merge this PR next week. Thank you all! |
|
@sunshaoce thanks for merging this. This PR was created with the following original problem microsoft/vscode-cpptools#6874. What is needed for vscode to use a version of lldb-mi with this new patch? |
|
Maybe you can PING them. |
|
This is handed here: microsoft/vscode-cpptools#11566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the command buffer with a std::string to support reading arbitrary command line lengths. This is required in projects like GStreamer that sets long environment variables like GST_PLUGIN_PATH with several directory paths on it.
microsoft/vscode-cpptools#8411
microsoft/vscode-cpptools#6874