clean-up code

llaville · Jul 1, 2024 · 61decc7 · 61decc7
1 parent 5966274
commit 61decc7
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/src/Builder/ArtifactChange.php b/src/Builder/ArtifactChange.php
@@ -15,7 +15,7 @@
  */
 final class ArtifactChange extends Declaration
 {
-    protected \Bartlett\Sarif\Definition\ArtifactLocation $artifactLocation;
+    protected Definition\ArtifactLocation $artifactLocation;
     /**
      * @var Definition\Replacement[] $replacements
      */

diff --git a/src/Definition/ExternalPropertyFileReference.php b/src/Definition/ExternalPropertyFileReference.php
@@ -13,8 +13,6 @@
 use Bartlett\Sarif\Property\LocationArtifact;
 use Bartlett\Sarif\Property\Properties;
 
-use DomainException;
-
 /**
  * An externalPropertyFileReference object contains information that enables a SARIF consumer
  * to locate the external property files that contain the values of all externalized properties associated with theRun.
@@ -49,7 +47,7 @@ final class ExternalPropertyFileReference extends JsonSerializable
      * @param ArtifactLocation|null $location
      * @param string $guid
      */
-    public function __construct(ArtifactLocation $location = null, string $guid = '')
+    public function __construct(?ArtifactLocation $location = null, string $guid = '')
     {
         if ($location instanceof ArtifactLocation) {
             $this->location = $location;

diff --git a/src/Definition/GraphTraversal.php b/src/Definition/GraphTraversal.php
@@ -16,9 +16,7 @@
 use Bartlett\Sarif\Property\ResultGraphIndex;
 use Bartlett\Sarif\Property\RunGraphIndex;
 
-use DomainException;
 use function is_int;
-use function is_numeric;
 
 /**
  * Represents a path through a graph.

diff --git a/src/Definition/Message.php b/src/Definition/Message.php
@@ -14,8 +14,6 @@
 use Bartlett\Sarif\Property\Properties;
 use Bartlett\Sarif\Property\Text;
 
-use DomainException;
-
 /**
  * Encapsulates a message intended to be read by the end user.
  *
@@ -52,11 +50,6 @@ final class Message extends JsonSerializable
 
     public function __construct(string $text = '', string $id = '')
     {
-        // Any of "id", "text" are required
-        if (empty($id) && empty($text)) {
-            throw new DomainException('Either "id" or "text" are required. Nothing provided.');
-        }
-
         $this->id = $id;
         $this->text = $text;