Avoid infinite loop in Datetime.bulk_create_datetimes by checking for positive timedelta
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
- Coverage 98.89% 98.79% -0.10%
==========================================
Files 57 57
Lines 1988 1990 +2
==========================================
Hits 1966 1966
- Misses 22 24 +2 |
lk-geimfari
approved these changes
Jun 22, 2022
| @@ -45,6 +45,11 @@ def test_bulk_create_datetimes_error(self, _datetime): | |||
| with pytest.raises(ValueError): | |||
| _datetime.bulk_create_datetimes(None, None) | |||
|
|
|||
| with pytest.raises(ValueError): | |||
There was a problem hiding this comment.
I don't get it. Why error should raise here if timedelta is positive in this particular case?
There was a problem hiding this comment.
Oh, I get it. It just incrementing date_start by timedelta(0) that make no sense.
|
@Wooza Thank you! This is a major bug actually. I'll publish new version ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we were evaluating our automated unit test generator on mimesis and found a bug in
Datetime.bulk_create_datetimes. It is possible to call this method without**kwargsor with**kwargsthat represent a non-positive timedelta. In such a case, thewhileloop in this method never terminates. I have added a simple check to verify that the used timedelta is positive and also added a test case for it.Checklist
I have read contributing guidelines
I'm sure that I did not unrelated changes in this pull request
I have created at least one test case for the changes I have made
I have added myself to the CONTRIBUTORS.rst
Best regards
Florian