Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fmt comments for black #229

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Add fmt comments for black #229

merged 1 commit into from
Aug 17, 2018

Conversation

whzup
Copy link
Collaborator

@whzup whzup commented Aug 16, 2018

Description

Added # fmt: off and # fmt: on comments to n-dimensional arrays in the test suite to prevent the ugly wrapping of arrays. Ran the black package to format the whole project.

Related Issue

Resolves: #201

Motivation and Context

The black package wrapped some n-dimensional arrays in the test suite pretty ugly.

How Has This Been Tested?

Looked at the marked arrays in the diff and it looks good. 👍

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@whzup
Add fmt comments for black
9ecd2f6 
Added fmt: off and fmt: on commments to n-dimensional arrays in the test suite to prevent the ugly wrapping of arrays. Ran the black package to format the whole project.

Resolves: #201
@whzup whzup added bug Bugs, bug fixes, etc. unit tests Test-related changes v.1.1.0 In pipeline for next version labels Aug 16, 2018
@whzup whzup requested a review from ljvmiranda921 August 16, 2018 15:12
ljvmiranda921
ljvmiranda921 approved these changes Aug 17, 2018
View reviewed changes
Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljvmiranda921 ljvmiranda921 merged commit f9dc37c into ljvmiranda921:development Aug 17, 2018
@ljvmiranda921 ljvmiranda921 mentioned this pull request Aug 17, 2018
Merged
9 tasks
@whzup whzup deleted the black-fmt branch August 19, 2018 13:16
ljvmiranda921 pushed a commit that referenced this pull request Jan 29, 2019
@whzup @ljvmiranda921
Add fmt comments for black (#229)
3e835fd 
Resolves: #201

Added fmt: off and fmt: on commments to n-dimensional arrays in the test suite to prevent the ugly wrapping of arrays. Ran the black package to format the whole project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljvmiranda921 ljvmiranda921 ljvmiranda921 approved these changes

Assignees

@ljvmiranda921 ljvmiranda921

@whzup whzup

Labels
bug Bugs, bug fixes, etc. unit tests Test-related changes v.1.1.0 In pipeline for next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whzup @ljvmiranda921