Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for plot_environment #30

Closed
ljvmiranda921 opened this issue Sep 21, 2017 · 1 comment
Closed

Add tests for plot_environment #30

ljvmiranda921 opened this issue Sep 21, 2017 · 1 comment
Assignees
@ljvmiranda921
Labels
enhancement Feature requests

Comments

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Sep 21, 2017 •
edited
Loading

Hi Contributor! This might get messy and unreadable because this is just a self-assigned issue that I will work on. In case you pieced out something from my garbled notes and want to help out, feel free to leave a comment below!

TODO:

  • Make sure that conda installs ffmpeg during setup.py and during travis check
  • Should it automatically install ffmpeg? Or have it as an option?
@ljvmiranda921 ljvmiranda921 self-assigned this Sep 21, 2017
ljvmiranda921 pushed a commit that referenced this issue Sep 21, 2017
TODO: Add test for plot_env (#30)
6727989 
Author: ljvmiranda921
Email: ljvmiranda@gmail.com
@ljvmiranda921 ljvmiranda921 added help wanted Help is much appreciated enhancement Feature requests and removed help wanted Help is much appreciated labels Sep 21, 2017
ljvmiranda921 pushed a commit that referenced this issue Sep 23, 2017
Add test for animation plots (#30)
cfd26bf 
This commit implements additional tests for the animation plots
in the environments module. Moreover, some docstrings were
changed to explicitly state the actual class being returned.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
ljvmiranda921 pushed a commit that referenced this issue Sep 23, 2017
Add test for animation plots (#30)
eaed6f0 
This commit implements additional tests for the animation plots
in the environments module. Moreover, some docstrings were
changed to explicitly state the actual class being returned.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
ljvmiranda921 pushed a commit that referenced this issue Sep 23, 2017
Add test for animation plots (#30)
516e5ee 
This commit implements additional tests for the animation plots
in the environments module. Moreover, some docstrings were
changed to explicitly state the actual class being returned.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
ljvmiranda921 pushed a commit that referenced this issue Sep 23, 2017
Add conda dependency (#30)
f94f800 
This commit aims to add a conda dependency to facilitate
the installation of ffmpeg. With the animators present,
we can then safely call methods from the
matplotlib.animation.FuncAnimation class.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
ljvmiranda921 pushed a commit that referenced this issue Sep 24, 2017
Add test_plot_environment dependencies (#30)
176a1cc 
This commit aims to resolve all dependency issues in the
matplotlib.animation.FuncAnimation when running the
test_plot_environment script.

A toolchain called libav-tools is installed in travis-ci,
and an if-else script checks if display is found. If not,
then it uses the default 'Agg' backend.

Moreover, the mock==2.0.0 package is also used during
tests as shown in setup.py.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
@ljvmiranda921
Copy link
Owner Author

Closing this issue as it was already solved by PR #31

ljvmiranda921 pushed a commit that referenced this issue Sep 24, 2017
Add test_plot_environment dependencies (#30)
f410600 
This commit aims to resolve all dependency issues in the
matplotlib.animation.FuncAnimation when running the
test_plot_environment script.

A toolchain called libav-tools is installed in travis-ci,
and an if-else script checks if display is found. If not,
then it uses the default 'Agg' backend.

Moreover, the mock==2.0.0 package is also used during
tests as shown in setup.py.

Author: ljvmiranda921
E-mail: ljvmiranda@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljvmiranda921 ljvmiranda921

Labels
enhancement Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljvmiranda921