Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] ES2018+: GetIterator, IterableToList, IteratorNext, IteratorStep, IteratorClose: use iterator records instead #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Nov 6, 2019

Depends on:


BREAKING CHANGE: This is backwards incompatible, as ES2017 and older operated directly on the Iterator instance.

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #68 into master will decrease coverage by 0.94%.
The diff coverage is 55.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   90.89%   89.94%   -0.95%     
==========================================
  Files         670       31     -639     
  Lines        9444     1781    -7663     
  Branches     2195      554    -1641     
==========================================
- Hits         8584     1602    -6982     
+ Misses        860      179     -681     
Impacted Files Coverage Δ
es2018.js 82.11% <55.93%> (-17.89%) ⬇️
es2019.js 88.23% <0.00%> (-11.77%) ⬇️
es2015.js 88.95% <0.00%> (-11.05%) ⬇️
es5.js 91.48% <0.00%> (-8.52%) ⬇️
es2016.js 92.68% <0.00%> (-7.32%) ⬇️
helpers/getSymbolDescription.js 93.75% <0.00%> (-6.25%) ⬇️
es2017.js 95.65% <0.00%> (-4.35%) ⬇️
helpers/mod.js 100.00% <0.00%> (ø)
helpers/getIteratorMethod.js 100.00% <0.00%> (ø)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8d479...cc8ca78. Read the comment docs.

@ljharb
Copy link
Owner

ljharb commented Dec 11, 2019

I rebased #67 but i think this one I'll leave to you :-)

@ExE-Boss ExE-Boss changed the title refactor(ES2018): Convert Iterator operations to use IteratorRecord [Breaking] 2018+: Convert Iterator operations to use IteratorRecord May 16, 2020
…, `IteratorStep`, `IteratorClose`: use iterator records instead
@ExE-Boss ExE-Boss force-pushed the refactor/es2018/iterator-record branch from 40da998 to cc8ca78 Compare June 14, 2020 16:50
@ExE-Boss ExE-Boss changed the title [Breaking] 2018+: Convert Iterator operations to use IteratorRecord [Breaking] ES2018+: GetIterator, IterableToList, IteratorNext, IteratorStep, IteratorClose: use iterator records instead Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants