Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Always use % for getting intrinsics #100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ExE-Boss
Copy link
Contributor

No description provided.

@ExE-Boss ExE-Boss changed the title [Fix]: Always use % for getting intrinsics [Refactor]: Always use % for getting intrinsics May 31, 2020
@ExE-Boss ExE-Boss force-pushed the fix/always-use-percent-for-intrinsics branch from 61c4ead to 945e629 Compare May 31, 2020 11:31
@ljharb
Copy link
Owner

ljharb commented Jun 1, 2020

What's the benefit here? If everything in this package uses % bookends, then there's nothing testing "not using %".

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jun 1, 2020

There is in the test files.

@ljharb
Copy link
Owner

ljharb commented Jun 1, 2020

True. What's the benefit of this change tho?

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jun 4, 2020

The benefit is consistency and making it possible to deprecate the non‑% form.

@ljharb
Copy link
Owner

ljharb commented Jun 4, 2020

I'm not sure why we'd want to deprecate it? callBound is the newest helper, and I intentionally left off the % for it.

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #100 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   91.03%   91.01%   -0.02%     
==========================================
  Files         647      647              
  Lines        8931     9031     +100     
  Branches     2109     2150      +41     
==========================================
+ Hits         8130     8220      +90     
- Misses        801      811      +10     
Impacted Files Coverage Δ
2018/IsStringPrefix.js 100.00% <ø> (ø)
2019/IsStringPrefix.js 100.00% <ø> (ø)
2015/AdvanceStringIndex.js 100.00% <100.00%> (ø)
2015/CreateHTML.js 100.00% <100.00%> (ø)
2015/CreateListFromArrayLike.js 96.66% <100.00%> (ø)
2015/GetSubstitution.js 98.41% <100.00%> (ø)
2015/InstanceofOperator.js 100.00% <100.00%> (ø)
2015/Invoke.js 100.00% <100.00%> (ø)
2015/IsArray.js 80.00% <100.00%> (ø)
2015/IsPromise.js 33.33% <100.00%> (ø)
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9cf6a...945e629. Read the comment docs.

@ljharb
Copy link
Owner

ljharb commented Sep 28, 2021

Depending on the progression of https://github.com/ljharb/proposal-get-intrinsic - in which I'm planning to not require the % - I'll be happy to rebase and land this PR once the proposal advances far enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants