record-tester: Further improvements for Catalyst E2E tests #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for that indirection, just another layer of copying around.
victorges
changed the title
But enforce output profiles if not provided
Remove default recordingSpec if not provided. Instead, just check there's at least 2 in response.
victorges
force-pushed
the
vg/feat/optional-source-check
branch
from
27aceac
to
bc3b33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-source-playbackflagrecord-testera bit to avoid copying around option vars.If anyone is reviewing this, go commit by commit as the above are kept separate.