core/vidplayer: add useful debug info to http response headers #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emranemran
requested review from
leszko,
RiccardoBiosas,
stronk-dev,
thomshutt,
AlexKordic and
cyberj0g
|
Looks like a test correctly failed - will fix the test once the initial review is done. |
|
@emranemran Could you please change reviewers to include 2 pers only? |
emranemran
commented
Jun 9, 2022
vidplayer/player.go
Outdated
| type VidPlayerDebug struct { | ||
| DebugEnabled bool | ||
| LivepeerVersion string | ||
| NodeType string |
There was a problem hiding this comment.
TODO: remove NodeType here as we'll always be looking at the broadcaster node for async HLS playback.
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-lpms
branch
from
6ff4891
to
f0b0183
Compare
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-lpms
branch
from
f0b0183
to
bafdabf
Compare
When viewing HLS manifests/segments, it is often useful to view information on how those segments were generated. This commit adds fields such as git-sha and node identifiers to the HTTP response headers.
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-lpms
branch
from
bafdabf
to
edfec46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing HLS manifests/segments, it is often useful to view
information on how those segments were generated. This commit adds
fields such as git-sha and node identifiers to the HTTP response
headers.