Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Orchestrator's latency metrics to Kafka events #3391

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 13, 2025

Add new Kafka event "discovery_results" with the following data:

[
   {
      "address":"0x4f83f45ca6afd4ec0df8ddfb3827de8ef9b91823",
      "latency_ms":"2",
      "url":"https://127.0.0.1:8936"
   },
   {
      "address":"04f83f45ca6afd4ec0df8ddfb3827de8ef9b91824",
      "latency_ms":"3",
      "url":"https://127.0.0.1:8937"
   }
]

This includes the latency from Gateway to each Orchestrator for each discovery process.

@github-actions github-actions bot added go Pull requests that update Go code labels Feb 13, 2025
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because of latency apparently - other than that, looks good

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.16336%. Comparing base (1c1c280) to head (d43dfcb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
discovery/discovery.go 52.38095% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3391         +/-   ##
===================================================
+ Coverage   32.15960%   32.16336%   +0.00376%     
===================================================
  Files            147         147                 
  Lines          40753       40770         +17     
===================================================
+ Hits           13106       13113          +7     
- Misses         26874       26883          +9     
- Partials         773         774          +1     
Files with missing lines Coverage Δ
common/types.go 0.00000% <ø> (ø)
discovery/discovery.go 86.30137% <52.38095%> (-5.94669%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1c280...d43dfcb. Read the comment docs.

Files with missing lines Coverage Δ
common/types.go 0.00000% <ø> (ø)
discovery/discovery.go 86.30137% <52.38095%> (-5.94669%) ⬇️

@leszko leszko merged commit 4fb4712 into master Feb 14, 2025
18 checks passed
@leszko leszko deleted the rafal/additional-metrics branch February 14, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants