Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yaml: Fix extraction of artifacts when preparing for release #3146

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

hjpotter92
Copy link
Member

https://discord.com/channels/423160867534929930/1275180318474895420

This should fix the issue during release step, where downloaded artifacts are being placed inside nested sub-directory since we bumped to upload-artifacts@v4.

@hjpotter92 hjpotter92 self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34447%. Comparing base (84d88af) to head (6f21344).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3146         +/-   ##
===================================================
- Coverage   57.35266%   57.34447%   -0.00819%     
===================================================
  Files             92          92                 
  Lines          15797       15801          +4     
===================================================
+ Hits            9060        9061          +1     
- Misses          6133        6136          +3     
  Partials         604         604                 

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45591da...6f21344. Read the comment docs.

@hjpotter92 hjpotter92 merged commit 8b4050d into master Aug 20, 2024
18 checks passed
@hjpotter92 hjpotter92 deleted the hjp/testing branch August 20, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants