-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchestrator: add flag to skip the availability check on startup #2928
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
===================================================
- Coverage 56.35345% 56.33991% -0.01354%
===================================================
Files 89 89
Lines 19454 19464 +10
===================================================
+ Hits 10963 10966 +3
- Misses 7882 7889 +7
Partials 609 609
Continue to review full report in Codecov by Sentry.
|
Currently testing on Singapore. Flag seems to have worked, let's see if work still comes in... |
Awesome, thanks @stronk-dev! Let me know once you're happy with the testing and we can merge |
Seems fine so far, any issues with the naming or comments? Wasn't sure what to group the new flag as |
Naming looks good, the only bit I'd maybe change would be the flag itself to be the full version - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @stronk-dev Looks good to me.
Agree with @thomshutt that we could rename the flag. Other than that LGTM. @thomshutt Feel free to merge this PR.
LGTM @stronk-dev, could you update the pending changelog please and then I'll merge |
…epeer#2928) * Orchestrator: add flag to skip the availability check on startup * Edit name of startup test param * Mod pending changelog --------- Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
What does this pull request do? Explain your changes. (required)
When booting an Orchestrator, an availability check is performed by sending a Ping GRPC request to the configured service address
On certain setups local loopback might not be available, causing the test to fail even though the Orchestrator is available from remote connections
This change adds a
testOrchAvail
flag to explicitly disable the startup checkHow did you test each of these updates (required)
Going to use the binaries built by this PR to test this on my Singapore node, which exhibits this issue