Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Update underlying livepeer-data/pkg/mistconnector dependency version #2225

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

hjpotter92
Copy link
Member

What does this pull request do? Explain your changes. (required)

Minor change (following up from #2196) to the livepeer-data/pkg/mistconnector package.

Specific updates (required)

  • Bump version from 0.4.8 to 0.4.11 which fixes the falsely reported boolean flag for integer values.

How did you test each of these updates (required)

Generated a binary locally, and tested with the falsy reported flag value:

  "maxGasPrice": {
    "name": "maxGasPrice",
    "help": "Maximum gas price (priority fee + base fee) for ETH transactions in wei, 40 Gwei = 40000000000",
    "option": "-maxGasPrice",
    "default": "0",
    "type": "uint"
  },
  "maxPricePerUnit": {
    "name": "maxPricePerUnit",
    "help": "The maximum transcoding price (in wei) per 'pixelsPerUnit' a broadcaster is willing to accept. If not set explicitly, broadcaster is willing to accept ANY price",
    "option": "-maxPricePerUnit",
    "default": "0",
    "type": "uint"
  },

earlier, both those flags were reported as bool

Does this pull request close any open issues?

Checklist:

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving merge conflicts

@hjpotter92 hjpotter92 merged commit 09ef673 into master Feb 3, 2022
@hjpotter92 hjpotter92 deleted the hjp/update-package branch February 3, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants