Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: Create realtime ratio histogram metric #1989

Merged
merged 5 commits into from
Jan 4, 2022
Merged

monitor: Create realtime ratio histogram metric #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee18e58
monitor: Create realtime ratio histogram metric
victorges Aug 10, 2021
7f3b0eb
monitor: Add some additional histogram buckets
victorges Aug 10, 2021
adbed8a
Update monitor/census.go
victorges Aug 23, 2021
e2d2975
Update monitor/census.go
victorges Aug 23, 2021
8913d60
Update CHANGELOG_PENDING
victorges Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

#### Broadcaster

- \#1989 Record realtime ratio metric as a histogram (@victorges)

#### Orchestrator

#### Transcoder
31 changes: 21 additions & 10 deletions monitor/census.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ type (
mSourceSegmentDuration *stats.Float64Measure
mHTTPClientTimeout1 *stats.Int64Measure
mHTTPClientTimeout2 *stats.Int64Measure
mRealtimeRatio *stats.Float64Measure
mRealtime3x *stats.Int64Measure
mRealtime2x *stats.Int64Measure
mRealtime1x *stats.Int64Measure
Expand Down Expand Up @@ -229,6 +230,7 @@ func InitCensus(nodeType NodeType, version string) {
}
census.mHTTPClientTimeout1 = stats.Int64("http_client_timeout_1", "Number of times HTTP connection was dropped before transcoding complete", "tot")
census.mHTTPClientTimeout2 = stats.Int64("http_client_timeout_2", "Number of times HTTP connection was dropped before transcoded segments was sent back to client", "tot")
census.mRealtimeRatio = stats.Float64("http_client_segment_transcoded_realtime_ratio", "Ratio of source segment duration / transcode time as measured on HTTP client", "rat")
census.mRealtime3x = stats.Int64("http_client_segment_transcoded_realtime_3x", "Number of segment transcoded 3x faster than realtime", "tot")
census.mRealtime2x = stats.Int64("http_client_segment_transcoded_realtime_2x", "Number of segment transcoded 2x faster than realtime", "tot")
census.mRealtime1x = stats.Int64("http_client_segment_transcoded_realtime_1x", "Number of segment transcoded 1x faster than realtime", "tot")
Expand Down Expand Up @@ -378,6 +380,13 @@ func InitCensus(nodeType NodeType, version string) {
TagKeys: baseTags,
Aggregation: view.Count(),
},
{
Name: "http_client_segment_transcoded_realtime_ratio",
Measure: census.mRealtimeRatio,
Description: "Ratio of source segment duration / transcode time as measured on HTTP client",
TagKeys: baseTags,
Aggregation: view.Distribution(0.5, 1, 2, 3, 5, 10, 50, 100),
},
{
Name: "http_client_segment_transcoded_realtime_3x",
Measure: census.mRealtime3x,
Expand Down Expand Up @@ -1118,19 +1127,21 @@ func SegmentFullyProcessed(segDur, processDur float64) {
if processDur == 0 {
return
}
xRealtime := processDur / segDur
ratio := segDur / processDur
var bucketM stats.Measurement
switch {
case xRealtime < 1.0/3.0:
stats.Record(census.ctx, census.mRealtime3x.M(1))
case xRealtime < 1.0/2.0:
stats.Record(census.ctx, census.mRealtime2x.M(1))
case xRealtime < 1.0:
stats.Record(census.ctx, census.mRealtime1x.M(1))
case xRealtime < 2.0:
stats.Record(census.ctx, census.mRealtimeHalf.M(1))
case ratio > 3:
bucketM = census.mRealtime3x.M(1)
case ratio > 2:
bucketM = census.mRealtime2x.M(1)
case ratio > 1:
bucketM = census.mRealtime1x.M(1)
case ratio > 0.5:
bucketM = census.mRealtimeHalf.M(1)
default:
stats.Record(census.ctx, census.mRealtimeSlow.M(1))
bucketM = census.mRealtimeSlow.M(1)
}
stats.Record(census.ctx, bucketM, census.mRealtimeRatio.M(ratio))
}

func AuthWebhookFinished(dur time.Duration) {
Expand Down