Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamer: Improve timestamp logic on status reporting #354

Merged
merged 2 commits into from
Dec 12, 2024
Merged

streamer: Improve timestamp logic on status reporting #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d47140
streamer: Serialize all status timestamps as ms
victorges Dec 11, 2024
83b47fa
streamer: Add timestamp to all emitted events
victorges Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions runner/app/live/streamer/streamer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,19 @@ def update_params(self, params: dict):
self.last_params_hash = str(hash(str(sorted(params.items()))))
return self

def model_dump(self, **kwargs):
data = super().model_dump(**kwargs)
# Convert all fields ending with _time to milliseconds
for field, value in data.items():
if field.endswith('_time'):
data[field] = _timestamp_to_ms(value)
return data


def _timestamp_to_ms(v: float | None) -> int | None:
return int(v * 1000) if v is not None else None


class PipelineStreamer:
def __init__(self, protocol: StreamProtocol, pipeline: str, input_timeout: int, params: dict):
self.protocol = protocol
Expand Down Expand Up @@ -175,6 +188,7 @@ async def report_status_loop(self):

async def _emit_monitoring_event(self, event: dict):
"""Protected method to emit monitoring event with lock"""
event["timestamp"] = _timestamp_to_ms(time.time())
async with self.report_status_lock:
try:
await self.protocol.emit_monitoring_event(event)
Expand Down
Loading