Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner/live/trickle: Fix publisher/subscribe lifecycle #324

Merged
merged 4 commits into from
Dec 9, 2024
Merged

runner/live/trickle: Fix publisher/subscribe lifecycle #324

merged 4 commits into from
Dec 9, 2024

Conversation

victorges
Copy link
Member

We weren't properly closing the sessions before so there was a warning from aiohttp

@victorges victorges requested a review from rickstaa as a code owner December 9, 2024 18:01
j0sh
j0sh approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down! One question about publisher.close already being called but otherwise LGTM

@victorges victorges force-pushed the vg/fix/trickle-sub-shtdown branch from affd13a to 3fc1968 Compare December 9, 2024 19:26
@victorges victorges merged commit 76b7240 into main Dec 9, 2024
5 of 9 checks passed
@victorges victorges deleted the vg/fix/trickle-sub-shtdown branch December 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0sh j0sh j0sh approved these changes

@rickstaa rickstaa Awaiting requested review from rickstaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorges @j0sh