Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slow resize #315

Merged
merged 4 commits into from
Dec 9, 2024
Merged

fix: slow resize #315

merged 4 commits into from
Dec 9, 2024

Conversation

varshith15
Copy link
Collaborator

The difference is almost 10x (PIL vs cv2)

Screenshot_2024-12-06_at_1 06 29_PM

Images are very similar:

Screenshot 2024-12-06 at 10 30 28 PM

@varshith15 varshith15 requested a review from rickstaa as a code owner December 6, 2024 17:19
@varshith15 varshith15 requested review from victorges and removed request for rickstaa December 6, 2024 17:19
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way as I think the extraneous processing should be relatively cheap

runner/app/live/streamer/streamer.py Outdated Show resolved Hide resolved
runner/app/live/streamer/streamer.py Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@varshith15 varshith15 merged commit 99d8425 into main Dec 9, 2024
8 of 9 checks passed
@varshith15 varshith15 deleted the fix/slow_resize branch December 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants