Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Fix startup of control API #300

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

victorges
Copy link
Member

@victorges victorges commented Dec 2, 2024

  • It should not always start, only if control_url is sent
  • It should get the PipelineStreamer, not the result of handler.wait()

Broken on #290

- It should not always start, only if control_url is sent
- It should get the PipelineStreamer, not the result of handler.wait()
@victorges victorges requested a review from rickstaa as a code owner December 2, 2024 21:33
@victorges victorges changed the title api: Start control API conditionally api: Fix startup of control API Dec 2, 2024
@victorges victorges merged commit 675f99a into main Dec 2, 2024
2 of 5 checks passed
@victorges victorges deleted the vg/fix/control-api-start branch December 2, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant