Allow requesting a ringtone during SIP call transfers #865
Conversation
🦋 Changeset detectedLatest commit: 3f00913 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
protobufs/rpc/sip.proto
Outdated
| @@ -99,4 +99,7 @@ message InternalCreateSIPParticipantResponse { | |||
| message InternalTransferSIPParticipantRequest { | |||
| string sip_call_id = 1; | |||
| string transfer_to = 2; | |||
|
|
|||
| // Optionally play ringtone to the SIP participant as an audible indicator of being transferred | |||
| bool play_ringtone = 3; | |||
There was a problem hiding this comment.
I guess this terminology is already there.. but technically this is the dialtone, not ringtone
There was a problem hiding this comment.
should we make a backwards compatible change now? wdyt @biglittlebigben @dennwc ?
There was a problem hiding this comment.
Yes, it's wrong, but everybody calls it that way, including our customers. I'm all for changing it, but by backward compatible change, do you mean "wire protocol compatible", ie rename the field with the same id, or code compatible (ie new field and play the dial tone if either of the boolean is true)?
There was a problem hiding this comment.
I was thinking code.. because we use twirp APIs.. and there isn't a clean way to change the column names there. but don't feel strongly that we need to change it.
There was a problem hiding this comment.
True for twirp. Folks will need to set both for some time, until we deploy the new flag everywhere, which is not ideal...
There was a problem hiding this comment.
Just renaming the field ought to be safe in the internal RPC protobuf though?
There was a problem hiding this comment.
yeah internal RPC is totally fine.
… benjamin/sip_transfer_ring
No description provided.