Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a clearer error message for invalid sandbox id #480

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add a clearer error message for invalid sandbox id #480

merged 3 commits into from
Dec 19, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Dec 18, 2024 •
edited
Loading

previously the command just said 404 Not Found and it wasn't obvious the problem was the sandbox param, vs the template param.

@bcherry bcherry requested a review from rektdeckard December 18, 2024 01:00
rektdeckard
rektdeckard approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@rektdeckard rektdeckard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏. Error self explanatory :)

@bcherry bcherry merged commit c786d93 into main Dec 19, 2024
3 checks passed
@bcherry bcherry deleted the bcherry/sandbox-404 branch December 19, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rektdeckard rektdeckard rektdeckard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcherry @rektdeckard