Add WHIP Simulcast Support #209
Conversation
| }) | ||
| } | ||
|
|
||
| func (sp *SDKMediaSink) SetWritePLI(quality livekit.VideoQuality, writePLI func()) *SDKMediaSinkTrack { |
There was a problem hiding this comment.
Do we need the extra setter here? From looking when SetWritePLI is called, it looks like we may be able to pass the writePLI function as a parameter to AddTrack?
There was a problem hiding this comment.
We do unfortunately :(
We create the tracks at signaling time. This is so we can block until they are all resolved.
We don’t know the SSRC until the media is flowing though.
| h.trackSDKMediaSinkLock.Lock() | ||
| defer h.trackSDKMediaSinkLock.Unlock() | ||
|
|
||
| if _, ok := h.trackSDKMediaSink[kind]; !ok { |
There was a problem hiding this comment.
Just curious about why we need two add all expected simulcast tracks when we get the first one here, instead of adding each one when we get the corresponding source track callback?
There was a problem hiding this comment.
We create the tracks at signaling time. This is so we can block until they are all resolved.
We don’t know the SSRC until the media is flowing though.
maybe a better way to do this. Don’t know yet
Sean-Der
force-pushed
the
sean-der/simulcast
branch
4 times, most recently
from
91055c9 to
0ac29ab
Compare
Sean-Der
force-pushed
the
sean-der/simulcast
branch
from
0ac29ab to
4385dcd
Compare
Sean-Der
force-pushed
the
sean-der/simulcast
branch
from
4385dcd to
6645cb6
Compare
## Changelog ### Added - Add EndedAt field to Ingress State (#40) - Log room name and participant ID (#191) - Gather input stats for url pull sessions (#192) - Add support for SRT in URL Pull ingress (#206) - Compute input media jitter (#205) - Gather pipeline output statistics (#207) - Add WHIP Simulcast Support (#209) ### Fixed - Use a secret token to authenticate relay connections (#186) - Update go-sdk to fix pli missed (#188) - Use new upstream go-gst repository (#189) - Refactor stats gathering functionality (#201) - Add nil check in media stats merging code (#204) - Do not use sample providers in the go SDK (#212)
## Changelog ### Added - Add EndedAt field to Ingress State (#40) - Log room name and participant ID (#191) - Gather input stats for url pull sessions (#192) - Add support for SRT in URL Pull ingress (#206) - Compute input media jitter (#205) - Gather pipeline output statistics (#207) - Add WHIP Simulcast Support (#209) ### Fixed - Use a secret token to authenticate relay connections (#186) - Update go-sdk to fix pli missed (#188) - Use new upstream go-gst repository (#189) - Refactor stats gathering functionality (#201) - Add nil check in media stats merging code (#204) - Do not use sample providers in the go SDK (#212)
No description provided.